Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trashcan icon for remove review request #13722

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Use trashcan icon for remove review request #13722

merged 2 commits into from
Nov 27, 2020

Conversation

jpraet
Copy link
Member

@jpraet jpraet commented Nov 27, 2020

Fixes #13721

Changes the icon for "Remove review request" from octicon-sync to octicon-trashcan.

image

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 27, 2020
@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels Nov 27, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 27, 2020
@codecov-io
Copy link

Codecov Report

Merging #13722 (996f550) into master (979fbe0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13722      +/-   ##
==========================================
- Coverage   42.25%   42.24%   -0.02%     
==========================================
  Files         697      697              
  Lines       76631    76631              
==========================================
- Hits        32384    32376       -8     
- Misses      38925    38933       +8     
  Partials     5322     5322
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
services/pull/check.go 48.90% <0.00%> (ø)
services/pull/pull.go 41.17% <0.00%> (+0.49%) ⬆️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 979fbe0...996f550. Read the comment docs.

@lafriks lafriks merged commit 3f13e07 into go-gitea:master Nov 27, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 27, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Change "Remove review request" icon
5 participants
@jpraet @codecov-io @lafriks @zeripath @GiteaBot